This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][PATCH v9 2/6] Implement alternative month names (bug 10871).


On Fri, Oct 27, 2017 at 1:03 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Fri, 27 Oct 2017, Zack Weinberg wrote:
>
>> The code changes look good to me, except for a few small concerns
>> listed below.  Also, before landing I would like Joseph Myers (cc:ed)
>> to positively confirm that this patch introduces no new ISO C or POSIX
>> conformance issues, and will not tie our hands if this or a similar
>> feature is standardized in the future.
>
> I believe this patch properly handles namespace issues and avoids any
> problems with improperly changing enum values or making them improperly
> depend on feature test macros defined.  I believe it properly deals with
> allowing existing locales using existing POSIX features to continue to
> work by copying the month values as needed.

Thanks.

> There should be a GCC bug filed, if there isn't one already, for allowing
> %OB / %Ob in strftime formats (with appropriate warnings in ISO C pedantic
> modes about being an extension).  Tests may need to disable errors for
> format warnings when built with a GCC version without that support.

I don't see any such bug in GCC bugzilla.  Would you mind filing one?

> Also, the POSIX proposal accepted for issue 8 has strptime %Ob and
> strptime %OB handled the same, despite that POSIX proposal not including
> strftime %Ob.  (This is only an argument for %Ob handling for strptime to
> go in this patch rather than the later one adding alternative abbreviated
> months, however.)

Since the entire patch series should be pushed at once anyway, let's
not make additional work for Rafal.

Could you point me at the accepted POSIX proposal, please?

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]