This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc/malloc.c: Mitigate null-byte overflow attacks


On 10/23/2017 10:29 AM, Moritz Eckert wrote:
> Since I didn't receive any reply yet, I wanted to make sure that's
> not because there is something wrong with the form of my patch
> proposal in general, or this being the wrong mailinglist for it?

You are on the right list.

This is the place to send patches like this for glibc.

You just need to ping your patch and keep pining. Everyone is busy.

A few things that would help your patch:

* Provide real-world numbers to backup your claim that it has a
  neutral performance impact. Alternatively show in the disassembly
  that the instruction critical path length is equivalent.

* Provide a test case that fails with the fix in place?

* Provide a more detailed discussion about why the code changes you
  made are the correct ones (something a reviewer would have to do).

Please review the contribution checklist:
https://sourceware.org/glibc/wiki/Contribution%20checklist

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]