This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Benchtests for sinf, cosf and sincosf
On 10/11/2017 06:05 AM, Joseph Myers wrote:
> On Wed, 11 Oct 2017, Siddhesh Poyarekar wrote:
>
>> On Tuesday 10 October 2017 09:36 PM, Rajalakshmi Srinivasaraghavan wrote:
>>> Numbers used from cos and sin inputs.
>>>
>>> 2017-10-10 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>>>
>>> * benchtests/Makefile (bench-math): Add sinf, cosf and sincosf.
>>> * benchtests/sincosf-inputs: New file.
>>> * benchtests/cosf-inputs: New file.
>>> * benchtests/sinf-inputs: New file.
>>
>> I think we need an include mechanisms for these files now, where you
>> could just do something like:
>>
>> ##include-inputs: sin
>
> I don't think that's appropriate for sharing between different types. The
> inputs for sin include many outside the range of float (which probably
> illustrates how unrepresentative they are of typical usage of sin), and we
> don't want the float test to have lots of infinities tested.
>
> Sharing inputs between sinf, cosf and sincosf may make much more sense.
I agree. I don't think we should share between IEEE types, but should share
inputs between functions that operate on the *same* type. For example we might
have a series of inputs that test ranges within the IEEE type, and then additional
input that test cut points for the function in question at varying levels of
input data points near such interesting cut points.
--
Cheers,
Carlos.