This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Hoist ZVA check out of the function
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 3 Oct 2017 17:21:34 +0530
- Subject: Re: [PATCH 1/2] Hoist ZVA check out of the function
- Authentication-results: sourceware.org; auth=none
- References: <1505834596-21641-1-git-send-email-siddhesh@sourceware.org> <f517f5a4-d813-d11b-3d74-467a21c712d9@linaro.org>
On Friday 29 September 2017 12:42 AM, Adhemerval Zanella wrote:
> I would use a more compact ChangeLog entry as:
>
> * sysdeps/aarch64/memset.S (do_no_zva, do_zva_64,
> do_zva_128, do_zva_default): New macro.
>
> Same for the other entries where it applies.
Done.
> You don't need use the default version for the loader, you can use the
> generic sysdeps/aarch64/memset.S by creating a rtld-memset.S on
> multiarch and defining the required macros.
Done.
> I would add a comment stating it is essentially doing libc_hidden_def(memset)
> and redirecting the internal implementation to __memset_generic.
Done.
> Although not strictly required, I think it should avoid build these
> for !IS_IN(libc) as for memset_zva.S. Same applied for memset_generic.S.
Done.
Posting updated patch shortly.
Thanks,
Siddhesh