This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] Rerun benchmarks only if *.out file does not exist.
- From: Steve Ellcey <sellcey at cavium dot com>
- To: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 25 Sep 2017 10:17:56 -0700
- Subject: Re: [RFC][PATCH] Rerun benchmarks only if *.out file does not exist.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1506123735.2286.174.camel@cavium.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, 2017-09-22 at 16:42 -0700, Steve Ellcey wrote:
>
>
> Two questions: One, does this sound useful to other people? And two, what
> is wrong with my patch? This patch mostly works but the bench-memcpy,
> bench-memcpy-large, and bench-memcpy-random tests get rerun everytime even
> if the .out files for those tests already exist. I don't know why. I am
> guessing is thas something to do with their common name prefix and the string
> manipulations done to test names in the Makefile but memset does not seem
> to have that problem.
>
> Steve Ellcey
> sellcey@cavium.com
Well, you can ignore the question about what is wrong with the patch, I
was removing the memcpy*.out files and that was why they got rerun. I
didn't see the rm command in my script and got confused.
While testing my changes I noticed that 'make bench-clean' does not
remove the *.out files. It removes the executables and object files
but not the *.out result files. So with my change 'make bench; make
bench-clean; make bench' resulted in the benchmarks getting rebuilt but
not rerun. I don't know if the decision to not remove *.out files was
intentional or an oversight.
Steve Ellcey
sellcey@cavium.com