This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] abort: Do not flush stdio streams [BZ #15436]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Andreas Schwab <schwab at suse dot de>
- Date: Wed, 20 Sep 2017 15:30:15 -0600
- Subject: Re: [PATCH] abort: Do not flush stdio streams [BZ #15436]
- Authentication-results: sourceware.org; auth=none
- References: <20170817133507.CEA5341DB79B0@oldenburg.str.redhat.com> <5453e6d9-11dd-5dce-f38f-4c8793864ddc@redhat.com> <1ded54c6-5796-b844-3cc5-9dbf21671c2d@redhat.com> <5e2d5837-3344-8710-f2c8-265d404c2205@redhat.com> <d916944d-479f-a13a-db47-e6a9736d60ef@redhat.com> <b1bd01cf-7298-c495-8e03-d5148f7219cc@redhat.com> <0f8e9f6b-18bb-f045-c662-ea6c468c78d6@redhat.com> <391ea70c-5650-a34c-cf73-473e463c7000@redhat.com> <32662610-dc0b-15da-30b5-e81753004086@redhat.com>
On 09/18/2017 08:33 AM, Florian Weimer wrote:
> On 08/30/2017 06:22 PM, Carlos O'Donell wrote:
>> On 08/30/2017 10:52 AM, Florian Weimer wrote:
>>> Here's an alternative patch which removes flushing completely. This is
>>> what Andreas suggested.
>>>
>>> I've added a short NEWS entry.
>>
>> Could you please also add a wiki note for
>> https://sourceware.org/glibc/wiki/Release/2.27#Packaging_Changes
>> which explains what happened and why?
>
> Do we have consensus for this patch? I haven't pushed it yet.
I thought we did :-)
However, if you, the author of the patch, aren't sure, then it is certainly
important to repost your patch and gather another round of review.
The key point is that we don't have to do this flushing if we don't have to
and it's hard to see anyone claiming they needed these exact semantics given
that abort() is an abnormal termination scenario.
> I originally had thought of it as more of a glibc-3.0-type project.
Sure, we should probably start to put together a wiki page with glibc-3.0
kinds of changes?
--
Cheers,
Carlos.