This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/9] posix: Allow glob to match dangling symlinks [BZ #866]



On 13/09/2017 06:14, Paul Eggert wrote:
> Adhemerval Zanella wrote:
>> Another approach that does not involve adding compat symbols (which adds
>> a lot of code complexity inside glibc build and do not solve 'make' builds
>> against new glibc) would to make GLOB_ALTDIRFUNCS to follow the old semantic
>> of using gl_stat instead of gl_lstat while making glob without GLOB_ALTDIRFUNCS
>> works as intended.  And add another flag, GLOB_ALTDIRFUNCS2, which actually
>> uses gl_lstat.
> 
> Although that's clever, it is a gratuitous source-code incompatibility with BSD, which is not a good thing. To some extent it's just GLOB_FOLLOW and GLOB_NOFOLLOW in disguise, and disguise is not a good thing in APIs. So I think I still prefer the compat symbol approach.
> 
> We'll get GNU 'Make' fixed, and I wouldn't worry overly much about people building unpatched 'Make' with new glibc. I filed a Make bug report is here:
> 
> http://lists.gnu.org/archive/html/bug-make/2017-09/msg00014.html

Right, I am mainly trying to avoid bring more internal glob implementation
complexity to glibc, but since you says the unpatched 'Make' built
against newer glibc shouldn't be a problem I think we can this way.
I will work on it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]