This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 3/5] ldbl-128ibm: Copy implementations from ldbl-128 instead of including them
On Sun, 10 Sep 2017, Gabriel F. T. Gomes wrote:
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_expl.c b/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> index 10df6bb7d5..3d32f8f0b0 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> @@ -69,7 +69,7 @@
> #define _Float128 long double
> #define L(x) x ## L
>
> -#include <sysdeps/ieee754/ldbl-128/t_expl.h>
> +#include <sysdeps/ieee754/ldbl-128ibm/t_expl.h>
Should just be #include "t_expl.h".
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> index 00bce29284..ec71904720 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> @@ -1,5 +1,867 @@
> -/* Looks like we can use ieee854 e_j0l.c as is for IBM extended format. */
> +/* Bessel function of order zero. IBM Extended Precision version.
> + Copyright (C) 2017 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +/* This file was copied from sysdeps/ieee754/ldbl-128/e_j0l.c. */
When copying you need to preserve the original copyright / license notice.
Note that this is copyright Stephen L. Moshier, not FSF.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c b/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/t_expl.h b/sysdeps/ieee754/ldbl-128ibm/t_expl.h
Likewise (this one is FSF-copyright, but should still have the dates
1999-2017 - but not the "Contributed by").
--
Joseph S. Myers
joseph@codesourcery.com