This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822]


On Sun, Sep 3, 2017 at 2:13 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 09/01/2017 07:59 PM, H.J. Lu wrote:
>>       (__qecvt_r): Likewise.
>>       (__qfcvt_r): Likewise.
>
> I think this change makes symbols vanish from the public ABI on various
> architectures:
>
> --- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist
> 2017-08-28 05:01:14.557643019 -0400
> +++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist
> 2017-09-03 05:07:32.110128081 -0400
> @@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F
> -GLIBC_2.3 qecvt_r F
> @@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F
> -GLIBC_2.3 qfcvt_r F
> @@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F
> -GLIBC_2.4 qecvt_r F
> @@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F
> -GLIBC_2.4 qfcvt_r F
>
> (I assume that the patch is identical to what is on the hjl/pr18822
> branch, which is what I used for testing.)

I updated hjl/pr18822 branch and there are no regressions with
build-many-glibcs.py.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]