This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Sat, 2 Sep 2017 22:58:28 +0200
- Subject: Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ECAF4859F7
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-19-hjl.tools@gmail.com>
On 09/01/2017 07:59 PM, H.J. Lu wrote:
> Mark internal utmp functions with attribute_hidden to allow direct
> access within libc.so and libc.a without using GOT nor PLT.
>
> [BZ #18822]
> * include/utmp.h (__updwtmp): Add attribute_hidden.
> (__utmpname): Likewise.
> (__getutent): Likewise.
I believe this causes:
/home/bmg/build/glibcs/s390-linux-gnu/glibc/login/utmpdump.o: In
function `main':
/home/bmg/build/glibcs/s390-linux-gnu/glibc-src/login/programs/utmpdump.c:93:
undefined reference to `getutent'
collect2: error: ld returned 1 exit status
That's presumably due to the renaming business in
sysdeps/unix/sysv/linux/s390/s390-32/getutent*.c
Thanks,
Florian