This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c are defined
- From: Florian Weimer <fweimer at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 31 Aug 2017 14:47:38 +0200
- Subject: Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c are defined
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8CE04C057F93
- References: <4919e435-9006-dd2d-8811-2a732f9fdac7@redhat.com> <CAKCAbMi17Aow_YMnv_vQCZ=W8Yop7j34n-+x0RfEWMzbTjYEoA@mail.gmail.com>
On 08/31/2017 02:30 PM, Zack Weinberg wrote:
> On Thu, Aug 31, 2017 at 8:14 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> libio lives exclusively in glibc these days, so there is no reason to
>> preserve _LIBC conditionals.
>>
>> While at it, I also removed some unnecessary indirections and conditions
>> on other always-defined macros (F_GETFL, EIO, etc.).
>>
>> I checked that this does not change the produced binaries on i686.
>
> LGTM.
>
> If you're in a mood to clean up libio, may I suggest going after
> _IO_MTSAFE_IO next? ;-)
After internal_function perhaps. _IO_MTSAFE_IO is quite hard because
it's not consistently defined across glibc.
Thanks,
Florian