This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v2] openpty: use TIOCGPTPEER to open slave side fd
- From: Andreas Schwab <schwab at suse dot de>
- To: Christian Brauner <christian dot brauner at ubuntu dot com>
- Cc: libc-alpha at sourceware dot org, stgraber at stgraber dot org, serge at hallyn dot com, fweimer at redhat dot com, joseph at codesourcery dot com
- Date: Mon, 28 Aug 2017 14:34:54 +0200
- Subject: Re: [PATCH 2/2 v2] openpty: use TIOCGPTPEER to open slave side fd
- Authentication-results: sourceware.org; auth=none
- References: <3496d984-a55e-d56b-2c25-a23200327dca@redhat.com> <20170828121106.2629-1-christian.brauner@ubuntu.com>
On Aug 28 2017, Christian Brauner <christian.brauner@ubuntu.com> wrote:
> diff --git a/login/openpty.c b/login/openpty.c
> index 8fbc66a3ef..43b34d7a9c 100644
> --- a/login/openpty.c
> +++ b/login/openpty.c
> @@ -87,9 +87,9 @@ openpty (int *amaster, int *aslave, char *name,
> const struct termios *termp, const struct winsize *winp)
> {
> #ifdef PATH_MAX
> - char _buf[PATH_MAX];
> + char _buf[PATH_MAX] = {0};
> #else
> - char _buf[512];
> + char _buf[512] = {0};
> #endif
No need to clear the whole array, just the first byte.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."