This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add hidden visibility to internal function prototypes

On 08/22/2017 01:39 PM, Joseph Myers wrote:
> On Tue, 22 Aug 2017, Florian Weimer wrote:
>>> As far as I know, linking those tests statically would be OK (it would not 
>>> significantly affect what they are testing).  That's atext-exp, 
>>> atest-sincos, atest-exp2 that are using internal GMP objects from libc.a; 
>>> I don't know if other tests, in math/ or elsewhere, also link against 
>>> particular libc.a objects.
>> I think the attached approach will work for the math subdirectory.
>> Tested on aarch64 and ppc64le.
>> I see additional aarch64 failures, though (outside math).
> To be clear: it works for math/ on top of having reapplied HJ's patch, but 
> there are still similar failures in other directories (on aarch64) in the 
> presence of HJ's patch?

See my other message.

Initially, I saw another build failure (with HJ's patch re-applied), but
I can't reproduce it.  I don't see any check/xcgeck/bench-build failures.

I did not check s390x, ppc, ppc64, though.  (Our lab automation is a bit
overloaded right now, so I can't get a machine reservation easily.)

But I think it should be possible to apply my patch and revert the revert.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]