This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Enable hidden visibility in libc.a compiled with PIE
On Mon, Aug 21, 2017 at 8:52 AM, Florian Weimer <firstname.lastname@example.org> wrote:
> On 08/21/2017 05:48 PM, Florian Weimer wrote:
>> On 08/08/2017 06:40 PM, H.J. Lu wrote:
>>> -#if defined SHARED || defined LIBC_NONSHARED
>>> +#if defined SHARED || defined LIBC_NONSHARED \
>>> + || (BUILD_PIE_DEFAULT && IS_IN (libc))
>>> # define attribute_hidden __attribute__ ((visibility ("hidden")))
>>> # define attribute_hidden
>> I think this broke “make subdirs=benchtests bench-build” because
>> json-lib.c is erroneously compiled with -DMODULE_NAME=libc.
Yes, this is
> I think this fixes it.
LGTM. Please add "[BZ #21864]" in ChangeLog entry.