This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 1/3] Mark __libc_multiple_libcs with attribute_hidden [BZ #18822]
On Mon, Aug 21, 2017 at 3:03 AM, Florian Weimer <firstname.lastname@example.org> wrote:
> On 08/20/2017 04:12 PM, H.J. Lu wrote:
>> +/* Set nonzero if we have to be prepared for more than one libc being
>> + used in the process. */
>> +extern int __libc_multiple_libcs attribute_hidden;
> I think the comment gives the wrong impression. The flag is not always
> set if there are multiple libcs in the process, and it certainly is not
> set just because we might end up having multiple libcs in the future
> (which is why the “have to be prepared” part irks me).
I copied it from csu/init-first.c:
/* Set nonzero if we have to be prepared for more than one libc being
used in the process. Safe assumption if initializer never runs. */
int __libc_multiple_libcs attribute_hidden = 1;
Should I just leave out the comments?