This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 2/4] Mark __internal_statvfs with attribute_hidden [BZ #18822]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 18 Aug 2017 06:15:37 -0700
- Subject: Re: [PATCH 2/4] Mark __internal_statvfs with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- References: <20170817205809.GA7760@gmail.com> <email@example.com>
On Fri, Aug 18, 2017 at 5:55 AM, Florian Weimer <firstname.lastname@example.org> wrote:
> On 08/17/2017 10:58 PM, H.J. Lu wrote:
>> Mark __internal_statvfs with attribute_hidden to allow direct access
>> to them within libc.so and libc.a without using GOT nor PLT.
>> Tested on i686 and x86-64. OK for master?
> This is a bit odd because the include/ headers are supposed to be
> generic, and the declarations you add are Linux-specific. In the past,
> we would have added a Linux-specific header under
> sysdeps/unix/sysv/linux for that.
> I don't have a strong opinion either way.
Header files under include override both generic and non-generic header
files. __KERNEL_STRICT_NAMES is another example.