This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Add ILP32 support to aarch64


On 17/08/17 16:44, Steve Ellcey wrote:
> On Thu, 2017-08-17 at 12:10 +0200, Andreas Schwab wrote:
>> elf_greg_t in <sys/procfs.h> is unsigned long, I think this should
>> become
>> unsigned long long.
>>
>> Andreas.
> 
> Yes, I think you are right about this.  I see x86_64 uses 'unsigned
> long long'.  Does using 'unsigned long long' seem better than
> using uint64_t like I did in makecontext.c?  uint64_t seems more
> descriptive of what the type really is.
> 

i think uint64_t should be preferred internally,
but in public headers the namespace rules have
to be followed which do not always allow the
inclusion of stdint.h

i guess sys/procfs.h does not have to follow any
special namespace rules since it's not a standard
header. there either approach is fine with me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]