This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] abort: Only flush file-based stdio streams before termination
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 17 Aug 2017 16:35:33 +0200
- Subject: Re: [PATCH] abort: Only flush file-based stdio streams before termination
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 666CA6A6AE
- References: <20170817133507.CEA5341DB79B0@oldenburg.str.redhat.com> <firstname.lastname@example.org>
On 08/17/2017 04:29 PM, Andreas Schwab wrote:
> On Aug 17 2017, email@example.com (Florian Weimer) wrote:
>> Historically, glibc flushes streams on abort, which is not
>> required by POSIX. This can trigger additional work
>> (including callbacks through function pointers) in processes
>> which are known to be in a bad state. After this change,
>> only streams which are backed by the standard descriptor-based
>> implementation are flushed.
> That still doesn't make abort thread-safe.
Do you mean async-signal-safe?
Sure, but I think it's an incremental improvement over what we have today.
I'm also fine with pulling all the flushing from abort. But I don't
know if we have consensus for that.