This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Mark internal functions with attribute_hidden


On Thu, Aug 17, 2017 at 6:12 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Thu, Aug 17, 2017 at 8:43 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Aug 17, 2017 at 5:37 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> On 08/17/2017 02:25 PM, H.J. Lu wrote:
>>>> Mark internal functions with attribute_hidden to allow direct access to
>>>> internal functions within libc.a without using GOT when the compiler
>>>> defaults to -fPIE.
>>>
>>> This explanation is a bit confusing.  I think this benefits other
>>> architectures, too.
>>
>> Yes, this is target independent.   It should benefit static PIE build for all
>> targets.  On x86, it bypasses GOT/PLT.
>
> Should internal_function just imply attribute_hidden?  Or is this
> inappropriate for some things marked internal_function?
>

No, we can't do that since internal_function is used on both internal
functions within libc as well as private functions between different
shared libraries.   internal_function controls how function parameters
are passed on i386.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]