This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Allow abort PLT references in for SH

On 08/15/2017 05:31 PM, Joseph Myers wrote:
> Given my patch
> <> for the
> ICEs building a glibc string function test for SH, the testsuite can
> build completely for SH with GCC 7 and mainline.  However, there is a
> test failure that does not appear for GCC 6: check-localplt fails
> because of an abort PLT reference in
> Given the lack of a trap insn pattern for SH, it seems unavoidable
> that the compiler might sometimes generate abort calls, and such abort
> calls (generated from __builtin_trap when there is no trap insn
> pattern) will be unaffected by the normal mapping to __GI_abort for
> calls within glibc.  Thus, this patch allows (but does not require) an
> abort PLT reference in for SH.
> Tested for sh4-linux-gnu with (GCC 7, with my
> patch applied).
> 2017-08-15  Joseph Myers  <>
> 	* sysdeps/unix/sysv/linux/sh/ Allow abort in
> diff --git a/sysdeps/unix/sysv/linux/sh/ b/sysdeps/unix/sysv/linux/sh/
> index 2753547..babb19d 100644
> --- a/sysdeps/unix/sysv/linux/sh/
> +++ b/sysdeps/unix/sysv/linux/sh/
> @@ -10,6 +10,8 @@ _Unwind_Find_FDE
> _exit
> __errno_location
> matherr
> +# Generated by the compiler because there is no trap insn pattern.
> abort ?
>  # The main malloc is interposed into the dynamic linker, for
>  # allocations after the initial link (when dlopen is used).
> malloc

I agree that this is a good temporary measure, but why can't gcc be
fixed to use what we use in glibc for ABORT_INSTRUCTION?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]