This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Test for profiling support (_mcount/gprof)


On 08/15/2017 03:34 PM, Andreas Schwab wrote:
> On Aug 15 2017, Florian Weimer <fweimer@redhat.com> wrote:
> 
>> diff --git a/gmon/tst-gmon-gprof.sh b/gmon/tst-gmon-gprof.sh
>> new file mode 100644
>> index 0000000000..b10a6e0763
>> --- /dev/null
>> +++ b/gmon/tst-gmon-gprof.sh
>> @@ -0,0 +1,59 @@
>> +#!/bin/sh
>> +# Check the output of gprof against a carfully crafted binary.
>> +# Copyright (C) 2017 Free Software Foundation, Inc.
>> +# This file is part of the GNU C Library.
>> +
>> +# The GNU C Library is free software; you can redistribute it and/or
>> +# modify it under the terms of the GNU Lesser General Public
>> +# License as published by the Free Software Foundation; either
>> +# version 2.1 of the License, or (at your option) any later version.
>> +
>> +# The GNU C Library is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +# Lesser General Public License for more details.
>> +
>> +# You should have received a copy of the GNU Lesser General Public
>> +# License along with the GNU C Library; if not, see
>> +# <http://www.gnu.org/licenses/>.
>> +
>> +LC_ALL=C
>> +export LC_ALL
>> +set -e
>> +exec 2>&1
>> +
>> +GPROF="$1"
>> +program="$2"
>> +data="$3"
>> +
>> +actual=$(mktemp)
>> +expected=$(mktemp)
>> +expected_dot=$(mktemp)
>> +cleanup () {
>> +    rm -f "$actual"
>> +    rm -f "$expected_dot"
>> +}
>> +trap cleanup 0
> 
> That doesn't clean $expected.
> 
> Ok with that change.

Thanks, pushed with a fix.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]