This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] powerpc: Add values from Linux 4.8 to <elf.h>
Hi Tulio,
On 15-08-2017 10:27, Tulio Magno Quites Machado Filho wrote:
> Gustavo Romero <gromero@linux.vnet.ibm.com> writes:
>
>> diff --git a/ChangeLog b/ChangeLog
>> index 56540f5..74faf23 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,19 @@
>> +2017-08-14 Gustavo Romero <gromero@linux.vnet.ibm.com>
>> +
>> + * elf/elf.h A (NT_PPC_TAR): New macro.
>> + (NT_PPC_PPR): Likewise.
>> + (NT_PPC_DSCR): Likewise.
>> + (NT_PPC_EBB): Likewise.
>> + (NT_PPC_PMU): Likewise.
>> + (NT_PPC_TM_CGPR): Likewise.
>> + (NT_PPC_TM_CFPR): Likewise.
>> + (NT_PPC_TM_CVMX): Likewise.
>> + (NT_PPC_TM_CVSX): Likewise.
>> + (NT_PPC_TM_SPR): Likewise.
>> + (NT_PPC_TM_CTAR): Likewise.
>> + (NT_PPC_TM_CPPR): Likewise.
>> + (NT_PPC_TM_CDSCR): Likewise.
>> +
>
> Please, don't add ChangeLog entries in the diff. Leave them in the commit
> message. That helps merging your patch.
OK, thanks for letting me know.
>> diff --git a/elf/elf.h b/elf/elf.h
>> index 3900b4c..2b05546 100644
>> --- a/elf/elf.h
>> +++ b/elf/elf.h
>> @@ -762,6 +762,19 @@ typedef struct
>> +#define NT_PPC_TM_CTAR 0x10d /* TM checkpointed Target Address Register */
>> +#define NT_PPC_TM_CPPR 0x10e /* TM checkpointed Program Priority Register */
>> +#define NT_PPC_TM_CDSCR 0x10f /* TM checkpointed Data Stream Control Register */
>
> Lines shouldn't have more than 79 characters.
>
> For more information about this, please take a look at this wiki page:
> https://sourceware.org/glibc/wiki/Contribution%20checklist
>
> I fixed these cosmetics issues and pushed your patch as ee72219a497b.
Thanks a lot for reviewing and pushing it.
Best regards,
Gustavo