This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Test for profiling support (_mcount/gprof)


On Aug 15 2017, Florian Weimer <fweimer@redhat.com> wrote:

> On 08/15/2017 02:28 PM, Andreas Schwab wrote:
>> On Aug 15 2017, Florian Weimer <fweimer@redhat.com> wrote:
>> 
>>> diff --git a/Makeconfig b/Makeconfig
>>> index 80aed2a987..19b559701a 100644
>>> --- a/Makeconfig
>>> +++ b/Makeconfig
>>> @@ -465,7 +465,8 @@ else  # not build-pie-default
>>>  +link-before-libc = $(CC) -nostdlib -nostartfiles -o $@ \
>>>  	      $(sysdep-LDFLAGS) $(LDFLAGS) $(LDFLAGS-$(@F)) \
>>>  	      $(combreloc-LDFLAGS) $(relro-LDFLAGS) $(hashstyle-LDFLAGS) \
>>> -	      $(addprefix $(csu-objpfx),$(start-installed-name)) \
>>> +	      $(or $(CRT-$(@F)), $ \
>>> +		$(addprefix $(csu-objpfx),$(start-installed-name))) \
>> 
>> $(or) is a 3.81 feature, we only require 3.79.  You can use $(firstword)
>> instead.
>
> Oh, good point.  $(firstword …) does not really align with the
> subsequent $(addprefix …) usage because that has the implication that
> $(start-installed-name) contains multiple words.

Other uses already require $(start-installed-name) to be a single word.
A lot of places use addprefix when not really needed.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]