This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: internal_function symbols part of the public ABI
On 08/14/2017 11:28 AM, Florian Weimer wrote:
> 2017-08-14 Florian Weimer <fweimer@redhat.com>
>
> [BZ #21962]
> NSS: Create stubs for accidentally exported lookup functions.
> * grp/initgroups.c (__nss_group_lookup, __nss_lookup_function):
> Remove declaration.
> * inet/ether_hton.c (__nss_ethers_lookup): Likewise.
> (ether_hostton): Call __nss_ethers_lookup2 instead.
> * inet/ether_ntoh.c (__nss_ethers_lookup): Remove declaration.
> (ether_ntohost): Call __nss_ethers_lookup2 instead.
> * inet/getnetgrent_r.c (__nss_netgroup_lookup): Remove declaration.
> (setup): Call __nss_netgroup_lookup2 instead.
> * nss/Makefile (routines): Add compat-lookup.
> * nss/Versions (GLIBC_2.27): Add symbol version.
> * nss/XXX-lookup (DB_LOOKUP_FCT): Remove declaration. Now provided by <nsswitch.h>.
> (DB_COMPAT_FCT): Remove.
> * nss/compat-lookup.c: New file.
> * nss/nsswitch.h: Generate __nss_*_lookup2 function prototypes
> from databases.def.
> * nss/service-lookup.c (NO_COMPAT): Remove definition.
> * sunrpc/netname.c (__nss_publickey_lookup): Remove declaration.
> (netname2user): Call __nss_publickey_lookup2 instead.
> * sunrpc/publickey.c (__nss_publickey_lookup): Remove declaration.
> (getpublickey, getsecretkey): Call __nss_publickey_lookup2
> instead.
This looks good to me.
This is a great cleanup of a bunch of crufty functions that we had around
for no real reason other than lack of time for cleanup.
We should be using new nscd with new glibc anyway and distros have been
enforcing that for years.
The only slight worry I have is that there were rumours of NSS service
modules using these interfaces, particularly during early bootup to
avoid lookup issues while services came online. I have never actually
seen such code, and I don't think we should make allowances for it.
Cheers,
Carlos.