This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386: Do not set internal_function

On 08/14/2017 02:32 PM, H.J. Lu wrote:
> On Mon, Aug 14, 2017 at 4:36 AM, Florian Weimer <> wrote:
>> All calls to functions with the internal_function attribute
>> have been removed from assembler implementations, which means that
>> the definition of internal_function can be changed at the C level
>> without causing ABI issues with assembler code.
>> _dl_fixup still uses a regparm calling convention on i386, but this
>> is controlled through ARCH_FIXUP_ATTRIBUTE, not internal_function.
>> 2017-08-14  Florian Weimer  <>
>>         i386: Do not set internal_function.
>>         * (USE_REGPARMS, internal_function): Remove.
>>         * sysdeps/i386/ (USE_REGPARMS): Likewise.
>>         * sysdeps/i386/configure (USE_REGPARMS): Likewise.
> Does include/libc-symbols.h still define internal_function?

Yes, the macro generic definition is still present, but it expands to

Completely removing internal_function is a separate cleanup.  I would
like to tackle this on a per-subdirectory basis once this change is in.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]