This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] i386: Do not set internal_function

All calls to functions with the internal_function attribute
have been removed from assembler implementations, which means that
the definition of internal_function can be changed at the C level
without causing ABI issues with assembler code.

_dl_fixup still uses a regparm calling convention on i386, but this
is controlled through ARCH_FIXUP_ATTRIBUTE, not internal_function.

2017-08-14  Florian Weimer  <>

	i386: Do not set internal_function.
	* (USE_REGPARMS, internal_function): Remove.
	* sysdeps/i386/ (USE_REGPARMS): Likewise.
	* sysdeps/i386/configure (USE_REGPARMS): Likewise.

diff --git a/ b/
index 22418576a0..014fb4ea0e 100644
--- a/
+++ b/
@@ -47,10 +47,6 @@
-/* Define if the regparm attribute shall be used for local functions
-   (gcc on ix86 only).  */
 /* Defined on SPARC if GCC emits GOTDATA relocations.  */
@@ -100,12 +96,6 @@
 #undef HAVE_AARCH64_BE
-/* Defined to some form of __attribute__ ((...)) if the compiler supports
-   a different, more efficient calling convention.  */
-#if defined USE_REGPARMS && !defined PROF
-# define internal_function __attribute__ ((regparm (3), stdcall))
 /* Linux specific: minimum supported kernel version.  */
diff --git a/sysdeps/i386/configure b/sysdeps/i386/configure
index 5b55c5affe..4d6685f7c2 100644
--- a/sysdeps/i386/configure
+++ b/sysdeps/i386/configure
@@ -77,8 +77,5 @@ if test $libc_cv_asm_mpx = yes; then
-$as_echo "#define USE_REGPARMS 1" >>confdefs.h
 $as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h
diff --git a/sysdeps/i386/ b/sysdeps/i386/
index 19ef33f34a..f7766ad2b8 100644
--- a/sysdeps/i386/
+++ b/sysdeps/i386/
@@ -45,8 +45,6 @@ if test $libc_cv_asm_mpx = yes; then
 dnl It is always possible to access static and hidden symbols in an
 dnl position independent way.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]