This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] __fortify_fail: Remove internal_function attribute
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sun, 13 Aug 2017 11:02:16 -0700
- Subject: Re: [PATCH] __fortify_fail: Remove internal_function attribute
- Authentication-results: sourceware.org; auth=none
- References: <20170812120513.F37704027587E@oldenburg.str.redhat.com>
On Sat, Aug 12, 2017 at 5:05 AM, Florian Weimer <fweimer@redhat.com> wrote:
> __fortify_fail is called across DSO boundaries, so it should not
> use a non-standard calling convention.
>
> 2017-08-12 Florian Weimer <fweimer@redhat.com>
>
> * debug/fortify_fail.c (__fortify_fail, __fortify_fail_abort):
> Remove internal_function.
> * include/stdio.h (__fortify_fail, __fortify_fail_abort): Likewise.
> * sysdeps/mach/hurd/i386/____longjmp_chk.S (CALL_FAIL): Pass
> message argument on the stack.
> * sysdeps/unix/sysv/linux/i386/____longjmp_chk.S (CALL_FAIL):
> Likeweise.
>
LGTM.
Thanks.
--
H.J.