This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [PATCH] sys/ptrace.h: remove obsolete Linux PTRACE_SEIZE_DEVEL constant

On Wed, Aug 09, 2017 at 10:19:30AM -0400, Carlos O'Donell wrote:
> On 08/09/2017 09:10 AM, Zack Weinberg wrote:
> > On Wed, Aug 9, 2017 at 6:39 AM, Florian Weimer wrote:
> >> On 08/08/2017 09:07 PM, Carlos O'Donell wrote:
> >>> On 08/08/2017 12:30 PM, Dmitry V. Levin wrote:
> >>>> On Tue, Aug 08, 2017 at 09:20:17AM -0400, Carlos O'Donell wrote:
> >>>>> On 08/07/2017 11:33 AM, Dmitry V. Levin wrote:
> I'm happy for Dmitry to commit them now that both you (Zack) and
> Florian have looked at the patches and consider the changes OK.
> Three developers is a good belt-and-suspenders peer review for
> multiple-machine header changes.

Wow, that was fast, thanks!

FIY, here is the timeline of this patch:
Tue, 18 Jul 2017: patch submitted
Wed, 02 Aug 2017: 2.26 released
Wed, 02 Aug 2017: patch ping
Mon, 07 Aug 2017: commit heads-up
Tue, 08 Aug 2017: first objection raised
Wed, 09 Aug 2017: first and second reviews
Wed, 09 Aug 2017: first objection removed
Wed, 09 Aug 2017: patch committed

Note that the ping after release attracted no attention for 5 days,
unlike the commit heads-up that caused all this discussion;
as result, the patch has been reviewed and committed.

Please do not consider this case as an example how one can expedite
a patch review! :)


Attachment: signature.asc
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]