This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #21745] powerpc: build some IFUNC math functions for libc and libm
- From: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- To: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, nix at esperi dot org dot uk
- Date: Tue, 8 Aug 2017 16:34:51 -0300
- Subject: Re: [PATCH] [BZ #21745] powerpc: build some IFUNC math functions for libc and libm
- Authentication-results: sourceware.org; auth=none
- References: <20170807132140.1733-1-tuliom@linux.vnet.ibm.com>
On Mon, 7 Aug 2017 10:21:40 -0300
"Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com> wrote:
> [BZ #21745]
> * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile:
> [$(subdir) = math] (sysdep_calls): New variable. Has the
> previous contents of sysdep_routines, but re-sorted..
Thanks for rewriting the logic to allow reuse.
> [$(subdir) = math] (sysdep_routines): Re-use the contents from
> sysdep_calls.
> [$(subdir) = math] (libm-sysdep_routines): Remove the functions
> defined in sysdep_calls and replace by the respective m_* names.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S:
> (compat_symbol): Undefine to avoid duplicated compat symbols in
> libc.
The patch looks good to me.