This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] i386: Add _startup_sbrk and _startup_fatal [BZ #21913]
On Mon, Aug 7, 2017 at 2:24 PM, Zack Weinberg <firstname.lastname@example.org> wrote:
> On Mon, Aug 7, 2017 at 5:17 PM, H.J. Lu <email@example.com> wrote:
>> Here is the updated patch. OK for master?
> Thanks for the quick turnaround!
> Please find a more logical place in libc-symbols.h for the definition
> of BUILD_PIE_DEFAULT; I didn't mean to suggest you should put it
> _immediately_ after the #include <config.h>. Otherwise, looks good to
I think that place isn't bad. I have a follwup patch to reduce the
size of libc.a when PIE is the default. It is better to define
> me, but please wait at least 48 hours for more feedback; this is not
> code I understand deeply, so I don't feel like I can be the sole