This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Added new Locale bho_NP
- From: AKHILESH KUMAR <akhilesh dot k at samsung dot com>
- To: Mike FABIAN <mfabian at redhat dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 28 Jul 2017 03:40:43 +0000
- Subject: Re: [PATCH 1/1] Added new Locale bho_NP
- Authentication-results: sourceware.org; auth=none
- Cms-type: 105P
- Dlp-filter: Pass
- References: <s9dpoclluli.fsf@redhat.com> <1501148857-15537-1-git-send-email-akhilesh.k@samsung.com> <CGME20170727095134epcas5p48ef9d1164ceef06a30d1f13c4ed6e9a5@epcms5p2>
- Reply-to: akhilesh dot k at samsung dot com
> > +category "i18n:2012";LC_COLLATE
> > +category "i18n:2012";LC_TIME
> > +category "i18n:2012";LC_NUMERIC
> > +category "i18n:2012";LC_MONETARY
> > +category "i18n:2012";LC_MESSAGES
> > +category "i18n:2012";LC_PAPER
> > +category "i18n:2012";LC_NAME
> > +category "i18n:2012";LC_ADDRESS
> > +category "i18n:2012";LC_TELEPHONE
> > +category "i18n:2012";LC_MEASUREMENT
> > +END LC_IDENTIFICATION
> > +
> > +LC_CTYPE
> > +copy "ne_NP"
> > +END LC_CTYPE
>
> copy "bho_IN"
>
> seems better, what do you think? The LC_CTYPE of ne_NP just does the
> standard copy "i18n", copy "bho_IN" would do copy "hi_IN" which does
> something with devanagari digits.
Agree
> > +LC_COLLATE
> > +copy "ne_NP"
> +END LC_COLLATE
> copy "bho_IN" will give the identical result but seems more logical.
Agree
> > +LC_MONETARY
> > +copy "ne_NP"
> > +END LC_MONETARY
> > +
> > +LC_NUMERIC
> > +copy "ne_NP"
> > +END LC_NUMERIC
> > +
> > +LC_TIME
> > +copy "bho_IN"
> > +END LC_TIME
>
> OK.
>
> > +LC_MESSAGES
> > +copy "hi_IN"
> > +END LC_MESSAGES
>
> Maybe better copy "bho_IN"? Although it makes no difference here.
Agree
All review Comments are integrated please find updated patch
https://sourceware.org/ml/libc-alpha/2017-07/msg00948.html
> > +LC_PAPER
> > +copy "ne_NP"
Akhilesh