This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: libc-2.25.90.pot
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: Benno Schulenberg <coordinator at translationproject dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Wed, 19 Jul 2017 12:40:03 +0530
- Subject: Re: libc-2.25.90.pot
- Authentication-results: sourceware.org; auth=none
- References: <8b9b4e60-f580-e56a-26bc-adb7192ba779@sourceware.org> <6e7f7602-3536-2edb-0cf4-e66a948fdb71@translationproject.org> <0961b9b1-b6b9-c0c9-bfe3-929ce522d7a8@sourceware.org>
- Reply-to: siddhesh at sourceware dot org, siddhesh at sourceware dot org
Looping libc-alpha into the response as well; I just noticed that you
pinged here too.
Siddhesh
On Wednesday 19 July 2017 12:38 PM, Siddhesh Poyarekar wrote:
> On Monday 17 July 2017 01:31 AM, Benno Schulenberg wrote:
>> I see these changes when compared to the previous POT file:
>>
>> -msgid "\"%s\", line %d: "
>> +msgid "\"%s\", line %"
>>
>> -msgid " (rule from \"%s\", line %d)"
>> +msgid " (rule from \"%s\", line %"
>>
>> Are you sure these changes are intentional? If yes, then maybe
>> they could use a translator hint, to say what is coming after the
>> last "%"? Also, since those strings are not marked as c-format,
>> a malicious translator might be able to crash the relevant program
>> by putting in %tralala or something instead of %s?
>
> It is a safe and intentional change; the full string is:
>
> "\"%s\", line %"PRIdLINENO": "
>
> where PRIdLINENO is PRIdMAX, which is a signed integer of maximum width,
> which could change for different architectures. It is however a numeric
> type.
>
> Would you like me to add a comment on top of that line to indicate that
> it is a numeric type? I reckon the string itself is self-explanatory.
>
> Siddhesh
>