This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Added Tongan language locale for Tonga
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>
- Cc: libc-alpha at sourceware dot org, Akhilesh Kumar <akhilesh dot k at samsung dot com>, hakbong5 dot lee at samsung dot com, pankaj dot m at samsung dot com
- Date: Mon, 17 Jul 2017 18:26:40 +0200
- Subject: Re: [PATCH v2] Added Tongan language locale for Tonga
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D5FD47A16A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5FD47A16A
- References: <CGME20170712105043epcas5p307a00302a6fbc5fdf9dab1cdd5d2cb49@epcas5p3.samsung.com> <1499856431-22027-1-git-send-email-akhilesh.k@samsung.com> <1808080170.67472.1500026565242@poczta.nazwa.pl>
Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> 12.07.2017 12:47 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>> [...]
>> +LC_MESSAGES
>> +%
>> https://www.tripadvisor.com/Travel-g294141-s604/Tonga:Important.Phrases.html
>> +% ^[+1yY]
>> +yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U005D>"
>> +% ^[-0nN]
>> +noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U005D>"
>> +% Yes -> 'Io
>> +yesstr "<U0027><U0049><U006F>"
>
> I know this is committed already but for consistency please
> use <U02BB> instead of <U0027>. I hope my suggestion is correct.
> Also I think it's correct to use the proper Turned comma character
> instead of default ASCII apostrophe in comments.
>
>> +% NO -> 'Ikai
>> +nostr "<U0027><U0049><U006B><U0061><U0069>"
>> +END LC_MESSAGES
>
> Likewise.
I committed the fix Rafal suggests.
--
Mike FABIAN <mfabian@redhat.com>