This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libio: Fix open_memstream flush (NULL)


On 13/07/17 15:06, Adhemerval Zanella wrote:
> On 12/07/2017 12:01, Florian Weimer wrote:
>> * Adhemerval Zanella:
>>> So do you prefer to just add a workaround to disable the single-thread
>>> optimization for open_memstream and fix it on 2.27?  IMHO this fix touches
>>> only the open_memstream itself, so it should not regress any other libio
>>> code so I would prefer than carry a workaround for 2.26.
>>
>> Which fix?  Linking open_memstream into the global list has quite
>> far-reaching consequences.  Conservatively setting the flag instead
>> should be fine.
> 
> I agree, but I also though adding the single-thread optimization close to
> freeze was also not the safe move.  I do not have a strong preference here
> and I think we can delay this fix to 2.27. 
> 

i think the single thread optimization is fine, but
it's better to just disable it for cases that are
problematic.

if there is no other complaints then i will commit
my patch tomorrow that disables the optimization
for open_memstream instead of reverting the entire
thing.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]