This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/1] New locale for bi_VU

From: Mike FABIAN <mfabian at redhat dot com>
To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
Cc: libc-alpha at sourceware dot org, pankaj dot m at samsung dot com, maninder1 dot s at samsung dot com
Date: Thu, 13 Jul 2017 18:30:50 +0200
Subject: Re: [PATCH 1/1] New locale for bi_VU
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1C7C44E03F
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C7C44E03F
References: <CGME20170713094706epcas5p3f8e0f5e17261120c6031320e5e6fc3f3@epcas5p3.samsung.com> <1499939026-33225-1-git-send-email-akhilesh.k@samsung.com>

Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21767]
>        * locales/bi_VU: New file.
>        * SUPPORTED: Add bi_VU/UTF-8.
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>

Suggested changes:

    diff --git a/localedata/locales/bi_VU b/localedata/locales/bi_VU
    index ed450eafe5..19d1aff25a 100755
    --- a/localedata/locales/bi_VU
    +++ b/localedata/locales/bi_VU
    @@ -3,7 +3,7 @@ escape_char /
     
     % Bislama language locale for Vanuatu.
     % Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>, Maninder Singh <maninder1.s@samsung.com>.
    -% Wrods translated from http://bislama.org/dbquery2.php
    +% Words translated from http://bislama.org/dbquery2.php

You are making the typo “Wrods” instead of “Words” again and again.
If you are copying this from somewhere, better fix it where you are
copying it from ...

     % http://www.bislama.org/translate
     % http://wikitravel.org/en/Bislama_phrasebook
     
    @@ -84,7 +84,7 @@ day	"<U0053><U0061><U006E><U0064><U0065>";/
     	"<U004D><U0061><U006E><U0064><U0065>";/
     	"<U0054><U0075><U0073><U0064><U0065>";/
     	"<U0057><U0065><U006E><U0065><U0073><U0064><U0065>";/
    -	"<U0054><U006F><U0073><U0064><U0065>>";/
    +	"<U0054><U006F><U0073><U0064><U0065>";/

One closing > too much, this would not compile.

     	"<U0046><U0072><U0061><U0065><U0064><U0065>";/
     	"<U0053><U0061><U0072><U0065><U0072><U0065>"
     %
    @@ -109,13 +109,10 @@ d_t_fmt     "<U0025><U0041><U0020><U0025><U0064><U0020><U0025><U0062>/
     d_fmt       "<U0025><U0041><U0020><U0025><U0064><U0020><U0025><U0062><U0020><U0025><U0059>"
     %
     % Appropriate time representation
    -% %I:%M:%S  %Z
    -t_fmt       "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0020><U0025><U005A>"
    -
    +% %I:%M:%S %Z
    +t_fmt       "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U005A>"
     % Equivalent of AM PM
    -am_pm	"<U092A><U0942><U0930><U094D><U0935><U093E><U0939><U094D><U0928>";/
    -"<U0905><U092A><U0930><U093E><U0939><U094D><U0928>"
    -%
    +am_pm	"<U0041><U004D>";"<U0050><U004D>"

You have Devanagari here in am_pm! That cannot be right for Bismali.
Bismali uses Latin script. My patch replaces it with English AM/PM.
But maybe you can find the real AM/PM strings for Bismali?
     %
     % Appropriate 12 h time representation (%r)
     % %I:%M:%S %p %Z
    @@ -151,7 +148,7 @@ p_sep_by_space		0
     n_cs_precedes		1
     int_n_sep_by_space	1
     n_sep_by_space		0
    -p_sign_posn			1	
    +p_sign_posn			1
     n_sign_posn			1
     END LC_MONETARY
     
    @@ -190,15 +187,20 @@ country_name "<U0056><U0061><U006E><U0075><U0061><U0074><U0075>"
     country_ab2  "<U0056><U0055>"
     % VUT
     country_ab3  "<U0056><U0055><U0054>"
    +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes
    +% VU
    +country_car  "<U0056><U0055>"

I think country_car should be "VU"

    +% https://en.wikipedia.org/wiki/ISO_3166-1_numeric
     country_num  548
     % https://en.wikipedia.org/wiki/Bislama
     % Bislama
     lang_name    "<U0042><U0069><U0073><U006C><U0061><U006D><U0061>"
    -% bi
    +% iso-639-1 "bi"
     lang_ab      "<U0062><U0069>"
    -% bis
    +% iso-639-3 "bis"
     lang_term    "<U0062><U0069><U0073>"
    -country_car  "<U0062><U0069><U0073>"

country_car did congain "bis" here, which seems wrong.

    +% iso-639-2 "bis"
    +lang_lib     "<U0062><U0069><U0073>"

lang_lib was missing.

     END LC_ADDRESS
     
     LC_TELEPHONE

-- 
Mike FABIAN <mfabian@redhat.com>

diff --git a/localedata/locales/bi_VU b/localedata/locales/bi_VU
index ed450eafe5..19d1aff25a 100755
--- a/localedata/locales/bi_VU
+++ b/localedata/locales/bi_VU
@@ -3,7 +3,7 @@ escape_char /
 
 % Bislama language locale for Vanuatu.
 % Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>, Maninder Singh <maninder1.s@samsung.com>.
-% Wrods translated from http://bislama.org/dbquery2.php
+% Words translated from http://bislama.org/dbquery2.php
 % http://www.bislama.org/translate
 % http://wikitravel.org/en/Bislama_phrasebook
 
@@ -84,7 +84,7 @@ day	"<U0053><U0061><U006E><U0064><U0065>";/
 	"<U004D><U0061><U006E><U0064><U0065>";/
 	"<U0054><U0075><U0073><U0064><U0065>";/
 	"<U0057><U0065><U006E><U0065><U0073><U0064><U0065>";/
-	"<U0054><U006F><U0073><U0064><U0065>>";/
+	"<U0054><U006F><U0073><U0064><U0065>";/
 	"<U0046><U0072><U0061><U0065><U0064><U0065>";/
 	"<U0053><U0061><U0072><U0065><U0072><U0065>"
 %
@@ -109,13 +109,10 @@ d_t_fmt     "<U0025><U0041><U0020><U0025><U0064><U0020><U0025><U0062>/
 d_fmt       "<U0025><U0041><U0020><U0025><U0064><U0020><U0025><U0062><U0020><U0025><U0059>"
 %
 % Appropriate time representation
-% %I:%M:%S  %Z
-t_fmt       "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0020><U0025><U005A>"
-
+% %I:%M:%S %Z
+t_fmt       "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U005A>"
 % Equivalent of AM PM
-am_pm	"<U092A><U0942><U0930><U094D><U0935><U093E><U0939><U094D><U0928>";/
-"<U0905><U092A><U0930><U093E><U0939><U094D><U0928>"
-%
+am_pm	"<U0041><U004D>";"<U0050><U004D>"
 %
 % Appropriate 12 h time representation (%r)
 % %I:%M:%S %p %Z
@@ -151,7 +148,7 @@ p_sep_by_space		0
 n_cs_precedes		1
 int_n_sep_by_space	1
 n_sep_by_space		0
-p_sign_posn			1	
+p_sign_posn			1
 n_sign_posn			1
 END LC_MONETARY
 
@@ -190,15 +187,20 @@ country_name "<U0056><U0061><U006E><U0075><U0061><U0074><U0075>"
 country_ab2  "<U0056><U0055>"
 % VUT
 country_ab3  "<U0056><U0055><U0054>"
+% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes
+% VU
+country_car  "<U0056><U0055>"
+% https://en.wikipedia.org/wiki/ISO_3166-1_numeric
 country_num  548
 % https://en.wikipedia.org/wiki/Bislama
 % Bislama
 lang_name    "<U0042><U0069><U0073><U006C><U0061><U006D><U0061>"
-% bi
+% iso-639-1 "bi"
 lang_ab      "<U0062><U0069>"
-% bis
+% iso-639-3 "bis"
 lang_term    "<U0062><U0069><U0073>"
-country_car  "<U0062><U0069><U0073>"
+% iso-639-2 "bis"
+lang_lib     "<U0062><U0069><U0073>"
 END LC_ADDRESS
 
 LC_TELEPHONE

References:
- [PATCH 1/1] New locale for bi_VU
  - From: Akhilesh Kumar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]