This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/1] aarch64: Add optimized version of sinf and cosf
On Thu, 6 Jul 2017, Ashwin Sekhar T K wrote:
> + double S0, S1, S2, S3, S4, y;
> +
> + S0 = -1.66666666666265311791406134034332e-01;
> + S1 = 8.33333332439092043519845987020744e-03;
> + S2 = -1.98412633515623692105969699817081e-04;
> + S3 = 2.75552591873811586009688362475245e-06;
> + S4 = -2.47545996176987174320511533257699e-08;
I think named constants should be declared as const and initialized,
rather than having runtime assignments (though such assignments will be
optimized away).
> +static double INVPIO4_TABLE[25] = {
And such an array should definitely be const.
--
Joseph S. Myers
joseph@codesourcery.com