Re: [PATCH 1/2] Add new Tok-Pisin locales.

[Mike FABIAN <mfabian at redhat dot com>]

Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21694]
> Added tok-pisin language locale for Papua New Guinea.
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/SUPPORTED      |   1 +
>  localedata/locales/tpi_PG | 218 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 219 insertions(+)
>  create mode 100644 localedata/locales/tpi_PG
>

[...]

> +% tok-pisin language locale for Papua New Guinea.
> +% Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>.
> +% Wrods translated from  http://www.tok-pisin.com/
     ^^^^^ typo
> +
> +LC_IDENTIFICATION
> +title       "tok-pisin language locale for Papua New Guinea"
> +source      "Samsung Electronics Co., Ltd."
> +address     ""
> +contact     ""
> +email       "akhilesh.k@samsung.com"
> +tel     	""
> +fax     	""
> +language    "tok-pisin"

Should be "Tok Pisin", I think.

> +LC_TIME
> +% Full month names
> +% Jenueri, Februeri, Mars, Epril, Mei, Jun, Julai , Ogas , Septemba,
> Oktoba, Novemba,Disemba
> +mon	"<U004A><U0065><U006E><U0075><U0065><U0072><U0069>";/
> +	"<U0046><U0065><U0062><U0072><U0075><U0065><U0072><U0069>"
> +	"<U004D><U0061><U0072><U0073>";/
> +	"<U0045><U0070><U0072><U0069><U006C>";/
> +	"<U004D><U0065><U0069>";/
> +	"<U004A><U0075><U006E>";/
> +	"<U004A><U0075><U006C><U0061><U0069>";/
> +	"<U004F><U0067><U0061><U0073>";/
> +	"<U0053><U0065><U0070><U0074><U0065><U006D><U0062><U0061>";/
> +	"<U004F><U006B><U0074><U006F><U0062><U0061>";/
> +	"<U004E><U006F><U0076><U0065><U006D><U0062><U0061>";/
> +	"<U0044><U0069><U0073><U0065><U006D><U0062><U0061>"
> +%
> +% Abbreviated month names
> +% Jen, Feb, Mar, Epr, Mei, Jun, Jul, Ogs, Sep, Okt, Nov, Dis
> +abmon	"<U004A><U0065><U006E>";/
> +	"<U0046><U0065><U0062>";/
> +	"<U004D><U0061><U0072>";/
> +	"<U0045><U0070><U0072>";/
> +	"<U004D><U0065><U0069>";/
> +	"<U004A><U0075><U006E>";/
> +	"<U004A><U0075><U006C>";/
> +	"<U004F><U0067><U0073>";/
> +	"<U0053><U0065><U0070>";/
> +	"<U004F><U006B><U0074>";/
> +	"<U004E><U006F><U0076>";/
> +	"<U0044><U0069><U0073>"

Your month names seem to come from
http://wikitravel.org/en/Tok_Pisin_phrasebook.
The month names differ a bit when looking them up using:
http://www.tok-pisin.com

Which month names are more trustworthy?

[...]

> +LC_MESSAGES
> +% ^[yY].*
> +yesexpr "<U005E><U005B><U0079><U0059><U005D><U002E><U002A>"
> +% ^[nN].*
> +noexpr  "<U005E><U005B><U006E><U004E><U005D><U002E><U002A>"
> +% yes
> +yesstr "<U0079><U0065><U0073>"
> +% Nogat
> +nostr "<U004E><U006F><U0067><U0061><U0074>"
> +END LC_MESSAGES

Maybe lowercase "nogat" instead of "Nogat", it would be weird
of the yesstr and nostr have different capitalization.

[...]

> +% Papua New Guinea
> +country_name
> "<U0050><U0061><U0070>U0075><U0061><U0020><U004E><U0065><U0077><U0020><U0047><U0075><U0069><U006E><U0065><U0061>"

The fourth code point lacks a <, i.e. here is a syntax error.

> +% http://laendercode.net/en/countries.html
> +country_ab3  "<U0050><U004E><U0047>"
> +country_car  "<U0050><U004E><U0047>"
> +country_num 598

OK, that is https://en.wikipedia.org/wiki/ISO_3166-1_numeric

> +% http://www.nationsonline.org/oneworld/international-calling-codes.htm
> +% Fix Me 
> +% country_num 675

That comment does not belong into the LC_ADDRESS section.

> +% Tok Pisin
> +lang_name    "<U0054><U006F><U006B><U0020><U0050><U0069><U0073><U0069><U006E>"
> +% https://en.wikipedia.org/wiki/Tok_Pisin
> +% lang_ab      "<U0074><U0070>"
> +% tpi

We could add

lang_ab      ""

to make it clear that there is no iso-639-1 code.

> +lang_term    "<U0074><U0070><U0069>"
> +lang_lib     "<U0074><U0070><U0069>"
> +END LC_ADDRESS
> +
> +LC_TELEPHONE
> +% https://www.howtocallabroad.com/papua/
> +% +%c ;%l
> +tel_int_fmt
> "<U002B><U0025><U0063><U0020><U003B><U0025><U0061><U0020><U003B><U0025><U006C>"

The comment does not agree with the entry, the comment says "%c ;%l"
but the data actually says 

tel_int_fmt "+%c ;%a ;%l"

As Papua New Guinea does not have area codes, I think "+%c %l" should be
OK.

> +% 00
> +int_select  "<U0030><U0030>"
> +% 675
> +int_prefix  "<U0036><U0037><U0035>"
> +END LC_TELEPHONE

-- 
Mike FABIAN <mfabian@redhat.com>