This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][PATCH v8 00/16][BZ 10871] Month names in alternative (nominative/genitive) case


On 06/28/2017 05:56 AM, Rafal Luzynski wrote:
> This is almost complete repost of my patches.  The previous series was
> posted on May 29. [1]  There are not many changes in this set, mostly it
> is rebase against the current master and applying some recent changes
> like using locale_t instead of __locale_t [2].

At this point these will have to wait for 2.27.  Hopefully we can get it
reviewed early in the 2.27 cycle so that there is time to find out if
there will be compatibility problems.

> This series also includes the backward compatibility features although
> Zack suggested to remove them. [3]  Feel free to skip the patches 2, 3,
> 6, 7, and 10 in this series.  My humble opinion is that these patches
> should be skipped.

It would be helpful if you would post a series without the compatibility
patches; reviewer time is, as always, limited, and given POSIX and BSD
both going for changing the behavior of %B, I really don't think we're
going to want the backward compatibility shims (Florian notwithstanding)
-- it would be *worse* to behave incompatibly with other operating systems.

> As always, documentation is missing because I'd like to hear first that
> the code (and which version of it) is acceptable.

Please write the documentation now.  For new features like this, it is
really helpful to read the new documentation *before* attempting to
review the code.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]