This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/5] Remove sysdep-cancel assembly macro


Ping (x3). The main idea of this patch, apart of cancellation refactor,
is to easier new port additions and we have two new candidates for next
release (ARC and RISCV).

On 13/06/2017 11:31, Adhemerval Zanella wrote:
> Ping (x2).
> 
> On 02/06/2017 09:51, Adhemerval Zanella wrote:
>> Ping.
>>
>> On 23/05/2017 15:25, Adhemerval Zanella wrote:
>>> This patchset finishes my previous work of Linux syscall consolidation
>>> and refactor to finally remove the requeriment of sysdeps-cancel.h
>>> assembly macros for cancellable syscalls.  All ports now uses the
>>> SYSCALL_CANCEL macros with C implementation which in turn calls
>>> INLINE_SYSCALL macros.
>>>
>>> Besides simplify the curent code requirement, it also simplify
>>> possible future ports to require only the C bindings and the direct
>>> assembly one for syscalls.list autogeneration (another possible
>>> work for future would be to use C generate binding to simplify
>>> even further the syscall requirements).
>>>
>>> I checked with a build for mostly supported architecture:
>>> aarch64-linux-gnu, alpha-linux-gnu, arm-linux-gnueabhi, i686-linux-gnu,
>>> ia64-linux-gnu, m68k-linux-gnu, microblaze-linux-gnu,
>>> mips{64,64n32}-linux-gnu, nios2-linux-gnu, powerpc{64,64le}-linux-gnu,
>>> s390{x}-linux-gnu, sh4-linux-gnu{-soft}, tile{pro,gx}-linux-gnu{-32},
>>> sparc{v9,64}-linux-gnu, and x86_64-linux-gnu.
>>>
>>> I also run a full make check on real hardware on aarch64-linux-gnu,
>>> arm-linux-gnueabihf, i686-linux-gnu, powerpc{64le}-linux-gnu,
>>> sparc{v9,64}-linux-gnu, and x86_64-linux-gnu{-x32}.
>>>
>>> Adhemerval Zanella (5):
>>>   Fix {INLINE,INTERNAL}_SYSCALL macros for x32
>>>   Remove p{read,write}{v} and fallocate from x86 auto-generation list
>>>   linux: Consolidate sync_file_range implementation
>>>   Consolidate Linux fcntl implementation
>>>   Remove cancellation support for syscall generation
>>>
>>>  ChangeLog                                          | 250 ++++++++++++++++++++
>>>  io/Makefile                                        |   1 -
>>>  sysdeps/unix/make-syscalls.sh                      |   4 -
>>>  sysdeps/unix/syscall-template.S                    |   7 +-
>>>  sysdeps/unix/sysv/linux/Makefile                   |   1 +
>>>  sysdeps/unix/sysv/linux/aarch64/sysdep-cancel.h    |  87 +------
>>>  sysdeps/unix/sysv/linux/alpha/sysdep-cancel.h      | 131 +----------
>>>  sysdeps/unix/sysv/linux/arm/fcntl.c                |   1 -
>>>  sysdeps/unix/sysv/linux/arm/sysdep-cancel.h        | 197 +---------------
>>>  sysdeps/unix/sysv/linux/fcntl.c                    |  52 ++---
>>>  .../unix/sysv/linux/generic/wordsize-32/fcntl.c    |  86 -------
>>>  sysdeps/unix/sysv/linux/hppa/fcntl.c               |   1 -
>>>  sysdeps/unix/sysv/linux/hppa/sysdep-cancel.h       | 236 +------------------
>>>  sysdeps/unix/sysv/linux/i386/fcntl.c               |  61 -----
>>>  sysdeps/unix/sysv/linux/i386/sysdep-cancel.h       | 119 +---------
>>>  sysdeps/unix/sysv/linux/ia64/sysdep-cancel.h       | 194 +---------------
>>>  sysdeps/unix/sysv/linux/m68k/fcntl.c               |   1 -
>>>  sysdeps/unix/sysv/linux/m68k/sysdep-cancel.h       | 108 +--------
>>>  sysdeps/unix/sysv/linux/microblaze/fcntl.c         |   1 -
>>>  sysdeps/unix/sysv/linux/microblaze/sysdep-cancel.h | 116 +---------
>>>  sysdeps/unix/sysv/linux/mips/mips32/fcntl.c        |   1 -
>>>  sysdeps/unix/sysv/linux/mips/mips64/n32/fcntl.c    |   1 -
>>>  .../unix/sysv/linux/mips/mips64/sysdep-cancel.h    | 249 --------------------
>>>  sysdeps/unix/sysv/linux/mips/sysdep-cancel.h       | 159 +------------
>>>  sysdeps/unix/sysv/linux/nios2/sysdep-cancel.h      | 110 +--------
>>>  sysdeps/unix/sysv/linux/powerpc/powerpc32/fcntl.c  |   1 -
>>>  .../sysv/linux/powerpc/powerpc32/sysdep-cancel.h   | 118 ----------
>>>  sysdeps/unix/sysv/linux/powerpc/powerpc64/fcntl.c  |  49 +---
>>>  .../sysv/linux/powerpc/powerpc64/sysdep-cancel.h   | 147 ------------
>>>  sysdeps/unix/sysv/linux/powerpc/sysdep-cancel.h    |  38 ++++
>>>  sysdeps/unix/sysv/linux/s390/s390-32/fcntl.c       |   1 -
>>>  .../unix/sysv/linux/s390/s390-32/sysdep-cancel.h   | 105 +--------
>>>  .../unix/sysv/linux/s390/s390-64/sysdep-cancel.h   | 109 +--------
>>>  sysdeps/unix/sysv/linux/sh/fcntl.c                 |   1 -
>>>  sysdeps/unix/sysv/linux/sh/sysdep-cancel.h         | 136 +----------
>>>  sysdeps/unix/sysv/linux/sparc/sparc32/fcntl.c      |   1 -
>>>  .../unix/sysv/linux/sparc/sparc32/sysdep-cancel.h  | 111 ---------
>>>  .../unix/sysv/linux/sparc/sparc64/sysdep-cancel.h  | 109 ---------
>>>  sysdeps/unix/sysv/linux/sparc/sysdep-cancel.h      |  38 ++++
>>>  sysdeps/unix/sysv/linux/tile/sysdep-cancel.h       | 123 +---------
>>>  sysdeps/unix/sysv/linux/wordsize-64/syscalls.list  |   1 -
>>>  sysdeps/unix/sysv/linux/x86_64/syscalls.list       |   4 -
>>>  sysdeps/unix/sysv/linux/x86_64/sysdep-cancel.h     |  62 +----
>>>  sysdeps/unix/sysv/linux/x86_64/sysdep.h            | 251 ++++++++++++---------
>>>  sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list   |   1 -
>>>  sysdeps/unix/sysv/linux/x86_64/x32/times.c         |  24 +-
>>>  46 files changed, 572 insertions(+), 3032 deletions(-)
>>>  delete mode 100644 sysdeps/unix/sysv/linux/arm/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/hppa/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/i386/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/m68k/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/microblaze/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/sysdep-cancel.h
>>>  delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep-cancel.h
>>>  delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep-cancel.h
>>>  create mode 100644 sysdeps/unix/sysv/linux/powerpc/sysdep-cancel.h
>>>  delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/sh/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/fcntl.c
>>>  delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/sysdep-cancel.h
>>>  delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/sysdep-cancel.h
>>>  create mode 100644 sysdeps/unix/sysv/linux/sparc/sysdep-cancel.h
>>>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]