This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Use clog10 not __clog10 in tgmath.h log10 macro [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 28 Jun 2017 16:45:04 +0000
- Subject: Use clog10 not __clog10 in tgmath.h log10 macro [committed]
- Authentication-results: sourceware.org; auth=none
As a GNU extension, for _GNU_SOURCE glibc's complex.h provides a
clog10 function and tgmath.h supports complex arguments to the log10
macro. However, tgmath.h uses __clog10 not clog10 in defining the
macro.
There is no namespace reason (ignoring the block-scope namespace
issues that would apply equally to *every* function called by tgmath.h
macros) for using __clog10 here, since this is only for _GNU_SOURCE so
clog10 is always visible when this macro definition is used.
Furthermore, __clog10f128 is not exported, so supporting _Float128 in
tgmath.h implies using clog10 not __clog10 there. (__clog10 and
clog10 aren't used in libstdc++ either, although that library would
have a good case for using the __clog10 reserved-namespace export: the
standard C++ library includes log10 of a complex number.) This patch
duly changes the header to use clog10, and enables tests of the macro
for complex arguments.
Tested for x86_64. Committed.
2017-06-28 Joseph Myers <joseph@codesourcery.com>
* math/tgmath.h [__USE_GNU] (log10): Use clog10 not __clog10.
* math/gen-tgmath-tests.py (Tests.add_all_tests): Test log10 for
complex arguments.
diff --git a/math/gen-tgmath-tests.py b/math/gen-tgmath-tests.py
index db6553e..31a3bd2 100755
--- a/math/gen-tgmath-tests.py
+++ b/math/gen-tgmath-tests.py
@@ -497,7 +497,9 @@ class Tests(object):
self.add_tests('lgamma', 'r', ['r'])
self.add_tests('llrint', 'long long int', ['r'])
self.add_tests('llround', 'long long int', ['r'])
- self.add_tests('log10', 'r', ['r'])
+ # log10 is real-only in ISO C, but supports complex arguments
+ # as a GNU extension.
+ self.add_tests('log10', 'g', ['g'])
self.add_tests('log1p', 'r', ['r'])
self.add_tests('log2', 'r', ['r'])
self.add_tests('logb', 'r', ['r'])
diff --git a/math/tgmath.h b/math/tgmath.h
index a0da104..7afe41e 100644
--- a/math/tgmath.h
+++ b/math/tgmath.h
@@ -319,7 +319,7 @@
/* Base-ten logarithm of X. */
#ifdef __USE_GNU
-# define log10(Val) __TGMATH_UNARY_REAL_IMAG (Val, log10, __clog10)
+# define log10(Val) __TGMATH_UNARY_REAL_IMAG (Val, log10, clog10)
#else
# define log10(Val) __TGMATH_UNARY_REAL_ONLY (Val, log10)
#endif
--
Joseph S. Myers
joseph@codesourcery.com