This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/6] PowerPC64 sysdep.h tidy
Alan Modra <amodra@gmail.com> writes:
> On Mon, Jun 12, 2017 at 03:12:22PM -0300, Tulio Magno Quites Machado Filho wrote:
>> Alan Modra <amodra@gmail.com> writes:
>>
>> > diff --git a/sysdeps/powerpc/powerpc64/sysdep.h b/sysdeps/powerpc/powerpc64/sysdep.h
>> > index 4347323..860420e 100644
>> > --- a/sysdeps/powerpc/powerpc64/sysdep.h
>> > +++ b/sysdeps/powerpc/powerpc64/sysdep.h
>> > @@ -106,25 +106,25 @@
>> > # define OPD_ENT(name) .quad BODY_LABEL (name), .TOC.@tocbase, 0
>> > #endif
>> >
>> > -#define ENTRY_1(name) \
>> > +#define ENTRY_1(name) \
>> > .type BODY_LABEL(name),@function; \
>> > .globl name; \
>> > .section ".opd","aw"; \
>> > - .align 3; \
>> > -name##: OPD_ENT (name); \
>> > - .previous;
>> > + .p2align 3;FUNC_LABEL(name): \
>> > + OPD_ENT (name); \
>> > + .previous
>>
>> I'm just curious: is this format written somewhere or used somewhere else?
>
> If you're referring to the label change, assembly labels generally
> start in the first column (or immediately after a semicolon). On
> targets that don't need a colon to mark a label that matters a lot,
> since an identifier starting in the first column is a label and
> anything past that is a directive or instruction.. PowerPC isn't such
> a target, but it's a good convention to follow. I know it doesn't
> look as nice the way the macro is written now.
That's what I was referring to.
> Hmm, perhaps I should change the relevant lines to:
>
> .p2align 3 \
> ;FUNC_LABEL(name): \
> OPD_ENT (name); \
I don't think that's necessary.
I was just trying to clarify what was behind this change in order to adhere
to the same convention next time.
Thanks!
--
Tulio Magno