This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix struct sigaltstack namespace (bug 21517)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Khem Raj <raj dot khem at gmail dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 13 Jun 2017 08:34:57 +0200
- Subject: Re: Fix struct sigaltstack namespace (bug 21517)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C2A6A80465
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2A6A80465
- References: <alpine.DEB.2.20.1705242232210.9182@digraph.polyomino.org.uk> <19d1c0b9-3c46-61cc-d874-93a7c2d43195@redhat.com> <CAMKF1sp6T0Tf6ySjDEjpB0Hkykfi11j76502FUKeEchpKf5J4Q@mail.gmail.com>
On 06/12/2017 11:15 PM, Khem Raj wrote:
> On Sat, Jun 3, 2017 at 8:55 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 05/25/2017 12:32 AM, Joseph Myers wrote:
>>> +* The stack_t type no longer has the name struct sigaltstack. This changes
>>> + the C++ name mangling for interfaces involving this type.
>>
>> I checked Fedora and we don't seem to have any ABI impact from this
>> change (no exported symbols matching /^_Z.*sigaltstack/), so this is
>> probably fine.
>
> I think gcc sanitizers will have issues since they are using
> the forward declaration of sigaltstack
>
> see
> https://github.com/gcc-mirror/gcc/blob/master/libsanitizer/sanitizer_common/sanitizer_linux.h#L22
There's already a bug for that:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81066
There is no ABI impact, so this is fixable.
Thanks,
Florian