This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: sellcey at cavium dot com, Steve Ellcey <sellcey at caviumnetworks dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: nd at arm dot com, libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 12 Jun 2017 17:26:22 +0100
- Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <1487781046.2866.153.camel@caviumnetworks.com> <alpine.DEB.2.20.1702221702490.8704@digraph.polyomino.org.uk> <1487879964.2866.181.camel@caviumnetworks.com> <alpine.DEB.2.20.1702240033550.6066@digraph.polyomino.org.uk> <1487980010.2866.198.camel@caviumnetworks.com> <593A60B1.6090100@arm.com> <593A7CEC.2040001@arm.com> <593E6999.6050405@arm.com> <1497284101.13346.104.camel@cavium.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 12/06/17 17:15, Steve Ellcey wrote:
> On Mon, 2017-06-12 at 11:14 +0100, Szabolcs Nagy wrote:
>>
>>>
>>> for some reason default-abi is lp64 in config.make,
>>> even though preconfigure set aarch64_config_abi to ilp32
>>>
>> this happened because the posted patch did not
>> have regenerated sysdeps/aarch64/configure
>
> My understanding that regenerated files should not be part of a patch
> (Wiki section 4.4). Maybe I should have included an explicit statement
thanks, i didn't know that
> about the need to run autoconf, I have certainly made that mistake (not
> running autoconf) myself a number of times. When I apply the patch, I
> do the following before building:
>
> (cd sysdeps/unix/sysv/linux/aarch64; autoconf -I../../../../..)
> (cd sysdeps/aarch64; autoconf -I../..)
>
> vi sysdeps/unix/sysv/linux/aarch64/configure
> # Change the linux kernel version check from 10.0 to whatever version
> # I am currently using.
>
> Steve Ellcey
> sellcey@cavium.com
>