This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] Add a way to bypass the PLT when calling getauxval
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>, pc at us dot ibm dot com, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Fri, 09 Jun 2017 15:34:22 +0200
- Subject: Re: [PATCHv2] Add a way to bypass the PLT when calling getauxval
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CCBAC61B8F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CCBAC61B8F
- References: <alpine.DEB.2.20.1705241951001.9182@digraph.polyomino.org.uk> <1495742765-1722-1-git-send-email-tuliom@linux.vnet.ibm.com> <87zidhb8xf.fsf@linux.vnet.ibm.com> <CAMe9rOou63sp--WS5cET8L82oXREsoGBwEmxYcX6eh_UZY0dsw@mail.gmail.com>
"H.J. Lu" <hjl.tools@gmail.com> writes:
>>> diff --git a/misc/getauxval.c b/misc/getauxval.c
>>> index c83fbce..14f4298 100644
>>> --- a/misc/getauxval.c
>>> +++ b/misc/getauxval.c
>>> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type)
>>> }
>>>
>>> weak_alias (__getauxval, getauxval)
>>> +libc_hidden_def (__getauxval)
>>> --
>>> 2.1.0
>>>
>
> Which one is better?
>
> https://sourceware.org/ml/libc-alpha/2017-06/msg00332.html
Tulio's patch is better because getauxval references could lead to
namespace violations.
Thanks,
Florian