Re: [PATCH 2/3] Add hidden_proto for getauxval

[Siddhesh Poyarekar <siddhesh at gotplt dot org>]

On Friday 09 June 2017 04:27 AM, Richard Henderson wrote:
> ---
>  include/sys/auxv.h | 2 ++
>  misc/getauxval.c   | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/sys/auxv.h b/include/sys/auxv.h
> index dede2c3..2e1f86b 100644
> --- a/include/sys/auxv.h
> +++ b/include/sys/auxv.h
> @@ -1 +1,3 @@
>  #include <misc/sys/auxv.h>
> +
> +libc_hidden_proto (getauxval)
> diff --git a/misc/getauxval.c b/misc/getauxval.c
> index c83fbce..458f58d 100644
> --- a/misc/getauxval.c
> +++ b/misc/getauxval.c
> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type)
>  }
>  
>  weak_alias (__getauxval, getauxval)
> +libc_hidden_weak (getauxval)

This is fine, but you could just merge this into 3/3 (where this gets
used first), which I won't review since I haven't looked at a powerpc
box in anger for years :)

Siddhesh