This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Update strlen.S to support wcslen/wcsnlen


On Tue, Jun 6, 2017 at 6:13 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Jun 6, 2017 at 5:59 AM, Markus Trippelsdorf
> <markus@trippelsdorf.de> wrote:
>> On 2017.06.06 at 05:37 -0700, H.J. Lu wrote:
>>> On Mon, Jun 5, 2017 at 10:37 PM, Markus Trippelsdorf
>>> <markus@trippelsdorf.de> wrote:
>>> >
>>> > It doesn't work on old machines without SSE4.1:
>>> >
>>> > FAIL: stdio-common/tstdiomisc
>>> > FAIL: wcsmbs/test-wcpncpy
>>> > FAIL: wcsmbs/test-wcsncmp
>>> > FAIL: wcsmbs/test-wcsncpy
>>> > FAIL: wcsmbs/test-wcsnlen
>>> > FAIL: wcsmbs/wcsatcliff
>>>
>>> Please try this.  Sorry for the breakage.
>>
>> It works fine now. Thanks for the quick patch.
>>
>
> I checked it in.
>

I checked in this patch to fold ifunc-sse4_1.h into wcsnlen.c.


-- 
H.J.
From 2e87c7d1582461044f8cd983fd9be121cf23803f Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 7 Jun 2017 09:04:40 -0700
Subject: [PATCH] x86-64: Fold ifunc-sse4_1.h into wcsnlen.c

Since ifunc-sse4_1.h is included only by wcsnlen.c, we can fold it
into wcsnlen.c.  No code changes in wcsnlen.o.

2017-06-07  H.J. Lu  <hongjiu.lu@intel.com>

	* sysdeps/x86_64/multiarch/ifunc-sse4_1.h: Removed and folded
	into ...
	* sysdeps/x86_64/multiarch/wcsnlen.c: Here.  Don't include
	ifunc-sse4_1.h.
---
 ChangeLog                               |  7 +++++++
 sysdeps/x86_64/multiarch/ifunc-sse4_1.h | 34 ---------------------------------
 sysdeps/x86_64/multiarch/wcsnlen.c      | 16 +++++++++++++++-
 3 files changed, 22 insertions(+), 35 deletions(-)
 delete mode 100644 sysdeps/x86_64/multiarch/ifunc-sse4_1.h

diff --git a/ChangeLog b/ChangeLog
index 4c06d7e..1106110 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-06-07  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* sysdeps/x86_64/multiarch/ifunc-sse4_1.h: Removed and folded
+	into ...
+	* sysdeps/x86_64/multiarch/wcsnlen.c: Here.  Don't include
+	ifunc-sse4_1.h.
+
 2017-06-07  Arjun Shankar  <arjun.is@lostca.se>
 
 	* sysdeps/unix/sysv/linux/ptsname.c (__ptsname_internal):
diff --git a/sysdeps/x86_64/multiarch/ifunc-sse4_1.h b/sysdeps/x86_64/multiarch/ifunc-sse4_1.h
deleted file mode 100644
index 2b89231..0000000
--- a/sysdeps/x86_64/multiarch/ifunc-sse4_1.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/* Common definition for ifunc selections optimized with SSE2 and SSE4.1.
-   All versions must be listed in ifunc-impl-list.c.
-   Copyright (C) 2017 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#include <init-arch.h>
-
-extern __typeof (REDIRECT_NAME) OPTIMIZE (sse2) attribute_hidden;
-extern __typeof (REDIRECT_NAME) OPTIMIZE (sse4_1) attribute_hidden;
-
-static inline void *
-IFUNC_SELECTOR (void)
-{
-  const struct cpu_features* cpu_features = __get_cpu_features ();
-
-  if (CPU_FEATURES_CPU_P (cpu_features, SSE4_1))
-    return OPTIMIZE (sse4_1);
-
-  return OPTIMIZE (sse2);
-}
diff --git a/sysdeps/x86_64/multiarch/wcsnlen.c b/sysdeps/x86_64/multiarch/wcsnlen.c
index 5f74d2c..304f62e 100644
--- a/sysdeps/x86_64/multiarch/wcsnlen.c
+++ b/sysdeps/x86_64/multiarch/wcsnlen.c
@@ -24,7 +24,21 @@
 # undef __wcsnlen
 
 # define SYMBOL_NAME wcsnlen
-# include "ifunc-sse4_1.h"
+# include <init-arch.h>
+
+extern __typeof (REDIRECT_NAME) OPTIMIZE (sse2) attribute_hidden;
+extern __typeof (REDIRECT_NAME) OPTIMIZE (sse4_1) attribute_hidden;
+
+static inline void *
+IFUNC_SELECTOR (void)
+{
+  const struct cpu_features* cpu_features = __get_cpu_features ();
+
+  if (CPU_FEATURES_CPU_P (cpu_features, SSE4_1))
+    return OPTIMIZE (sse4_1);
+
+  return OPTIMIZE (sse2);
+}
 
 libc_ifunc_redirected (__redirect_wcsnlen, __wcsnlen, IFUNC_SELECTOR ());
 weak_alias (__wcsnlen, wcsnlen);
-- 
2.9.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]