This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 0/4] aarch64: Allow overriding HWCAP_CPUID feature check
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org
- Cc: adhemerval dot zanella at linaro dot org
- Date: Fri, 26 May 2017 13:13:37 -0700
- Subject: Re: [PATCH v3 0/4] aarch64: Allow overriding HWCAP_CPUID feature check
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=cavium.com;
- References: <1495743960-23665-1-git-send-email-siddhesh@sourceware.org>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, 2017-05-26 at 01:55 +0530, Siddhesh Poyarekar wrote:
>
> I have not reposted the earlier 1/5, 2/5 and 4/5 since they have been acked.
> I'll push them in together with all these patches since it did not make sense to
> put them in isolation.
>
> Tested on x86_64 and aarch64.
Siddhesh, does this mean that if I apply these four patches plus
patches 1, 2, and 4 from the earlier set (https://sourceware.org/ml/lib
c-alpha/2017-05/msg00570.html) then I should get the override
functionality?
I have applied those patches, the earlier patch 1 of 5 did not apply
cleanly but I think I fixed that by hand correctly and I had to fix up
the documentation problem that was mentioned in the email but the
override is not working correctly for me (or I am misunderstanding
things).
I wrote a small program to call __libc_ifunc_impl_list and see what
memcpy versions were available on thunderx. I see both versions but
the usable flag is 0 for the thunderx version on my thunderx machine
even if I do not set HWCAP_MASK to anything. When I build the library
with out --enable-tunable, then I get a usable flag of 1 for both
versions of memcpy which is what I would expect. Are there any other
patches I need?
Steve Ellcey
sellcey@cavium.com