This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, libc-alpha at sourceware dot org
Cc: Carlos O'Donell <carlos at redhat dot com>
Date: Mon, 22 May 2017 17:18:02 -0300
Subject: Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
Authentication-results: sourceware.org; auth=none
References: <1493996954-14556-1-git-send-email-adhemerval.zanella@linaro.org> <c317cea0-dc50-cbc0-8785-2293c74e4365@gotplt.org> <bb30bbce-3e36-a852-d440-fcad55006704@linaro.org> <352a1abe-d4ba-322f-ed9d-158f7cd56e8e@gotplt.org> <aca141a5-b534-4c2b-331a-16c97c533f56@linaro.org> <4817c3dd-dbd8-3882-6e7d-1b8d6d74b342@gotplt.org>


On 22/05/2017 17:04, Siddhesh Poyarekar wrote:
> On Monday 22 May 2017 10:55 PM, Adhemerval Zanella wrote:
>>  If the operation fails, a null pointer is returned; otherwise,
>> -@code{freopen} returns @var{stream}.
>> +@code{freopen} returns @var{stream}.  Also for Linux, due internal dup3
>> +usage, it might fail with errno set to EBUSY during a race condition
>> +with @code{open} and @code{dup}.
> 
> On Linux, @code{freopen} may fail and set @code{errno} to @{EBUSY} when
> the kernel structure for the old file descriptor was not initialized
> completely before @code{freopen} was called.
> 
> OK with that change.
> 
> Siddhesh
> 

Alright, I will change it (I based this doc from freopen(3) btw).

Follow-Ups:
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Siddhesh Poyarekar

References:
- [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Adhemerval Zanella
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Siddhesh Poyarekar
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Adhemerval Zanella
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Siddhesh Poyarekar
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Adhemerval Zanella
- Re: [PATCH] libio: Avoid dup already opened file descriptor [BZ#21393]
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]