This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Consolidate code to get hwcap_mask into GET_HWCAP_MASK macro
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: libc-alpha at sourceware dot org
- Cc: adhemerval dot zanella at linaro dot org
- Date: Mon, 22 May 2017 23:51:10 +0530
- Subject: Re: [PATCH] Consolidate code to get hwcap_mask into GET_HWCAP_MASK macro
- Authentication-results: sourceware.org; auth=none
- References: <1495140169-32707-1-git-send-email-siddhesh@sourceware.org>
- Reply-to: siddhesh at sourceware dot org
On Friday 19 May 2017 02:12 AM, Siddhesh Poyarekar wrote:
> /* XXX The following is wrong! Dave Miller rejected to implement it
> correctly. If this causes problems shoot *him*! */
> -#ifdef SHARED
> -# if HAVE_TUNABLES
> - uint64_t hwcap_mask = TUNABLE_GET (glibc, tune, hwcap_mask, uint64_t);
> -# else
> - uint64_t hwcap_mask = GLRO(dl_hwcap_mask);
> -# endif
> + uint64_t hwcap_mask = GET_HWCAP_MASK();
Ugh, this is so wrong, good thing I noticed before I would have got shot :)
I'll fix this up.
Siddhesh