This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Committed: Remove __need macros from signal.h.


On Sun, May 21, 2017 at 3:19 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> /usr/include/bits/types/siginfo_t.h:6:33: fatal error: bits/types/sigval_t.h: No such file or directory
>  #include <bits/types/sigval_t.h>

Fixed by appended patch.

Given the difficulty of test-installing glibc and then testing
compilation with it, I would have appreciated somewhat more
explanation of what the problem was, e.g. including the words "Any
program that includes signal.h fails to compile against an installed
glibc with this patch applied" in your message would have saved me
from a couple of false leads.

zw

    * signal/Makefile (headers): Add bits/types/sigval_t.h.
---
 ChangeLog       | 4 ++++
 signal/Makefile | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 62341b8ed3..ce060eb8de 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-21  Zack Weinberg  <zackw@panix.com>
+
+    * signal/Makefile (headers): Add bits/types/sigval_t.h.
+
 2017-05-20  Zack Weinberg  <zackw@panix.com>

     * bits/sigevent-consts.h
diff --git a/signal/Makefile b/signal/Makefile
index de92558f2c..9ce8232d43 100644
--- a/signal/Makefile
+++ b/signal/Makefile
@@ -28,8 +28,8 @@ headers := signal.h sys/signal.h \
        bits/sigstack.h bits/sigthread.h bits/ss_flags.h \
        bits/types/__sigset_t.h bits/types/sig_atomic_t.h \
        bits/types/sigevent_t.h bits/types/siginfo_t.h \
-       bits/types/sigset_t.h bits/types/stack_t.h \
-       bits/types/struct_sigstack.h
+       bits/types/sigset_t.h bits/types/sigval_t.h \
+       bits/types/stack_t.h bits/types/struct_sigstack.h

 routines    := signal raise killpg \
            sigaction sigprocmask kill \
-- 
2.11.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]